ekovacs commented on a change in pull request #3351: NIFI-2933 Remote
input/output ports at any PG
URL: https://github.com/apache/nifi/pull/3351#discussion_r269444782
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/PortDTO.java
##########
@@ -171,4 +172,18 @@ public void setValidationErrors(Collection<String>
validationErrors) {
this.validationErrors = validationErrors;
}
+
+ /**
+ * @return whether this port can be accessed remotely via Site-to-Site
protocol.
+ */
+ @ApiModelProperty(
+ value = "Whether this port can be accessed remotely via
Site-to-Site protocol."
+ )
+ public Boolean isAllowRemoteAccess() {
Review comment:
is this intentionally a non primitive type? if so the method should read as
getAllowRemoteAccess.
only primitve boolean type 'getter' methods should start with `is`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
