mattyb149 commented on a change in pull request #3318: NiFi-5537 Add Cypher Bundle URL: https://github.com/apache/nifi/pull/3318#discussion_r270521725
########## File path: nifi-nar-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/AbstractGraphExecutor.java ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.graph; + +import org.apache.nifi.annotation.lifecycle.OnScheduled; +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.graph.GraphClientService; +import org.apache.nifi.expression.ExpressionLanguageScope; +import org.apache.nifi.flowfile.FlowFile; +import org.apache.nifi.processor.AbstractProcessor; +import org.apache.nifi.processor.ProcessContext; +import org.apache.nifi.processor.Relationship; +import org.apache.nifi.processor.util.StandardValidators; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +/** + * Abstract base class for ExecuteGraphQuery processors + */ +abstract class AbstractGraphExecutor extends AbstractProcessor { + public static final PropertyDescriptor CLIENT_SERVICE = new PropertyDescriptor.Builder() + .name("graph-client-service") + .displayName("Client Service") + .description("The graph client service for connecting to the graph database.") + .required(true) + .identifiesControllerService(GraphClientService.class) + .build(); + public static final PropertyDescriptor QUERY = new PropertyDescriptor.Builder() + .name("graph-query") + .displayName("Graph Query") + .description("Specifies the graph query.") + .required(true) Review comment: Could we make this not required and use the flow file contents if the property is not specified? I'm thinking of cases where you might need to build out a complex Cypher or Gremlin query in the contents rather than an attribute. The behavior would be consistent with other processors like ExecuteSQL. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
