ijokarumawak opened a new pull request #3401: NIFI-6160 NIFI-6170 Apply config error handling convention URL: https://github.com/apache/nifi/pull/3401 What this PR changed: - Standardized required name error message to 'The name of the xxxx must be specified' - Added nfErrorHandler.handleConfigurationUpdateAjaxError - Replaced existing custom error handling for 400 status code - Replaced handleAjxError with this where appropriate - Standardized config error dialog title to 'Configuration Error' - Close the configuration dialog when configuration is successfully updated Above convention applied to following components: - ProcessGroup - Input/OutputPort - RemoteProcessGroup - RemoteGroupPort - Template - Connection - ControllerService - Label - Processor - ReportingTask - NiFi Settings/GENERAL tab - Variable - User Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
