kevdoran commented on a change in pull request #3257: NIFI-5435 Prometheus /metrics http endpoint for monitoring integration URL: https://github.com/apache/nifi/pull/3257#discussion_r272291379
########## File path: nifi-nar-bundles/nifi-prometheus-bundle/nifi-prometheus-nar/src/main/resources/META-INF/NOTICE ########## @@ -0,0 +1,44 @@ +Copyright 2015-2017 The Apache Software Foundation Review comment: This NOTICE file seems to need quite a bit of work. Dependency artifacts I do not see covered in this NOTICE (in addition, please make sure that anything in this notice is also included in the nifi-assembly notice, as this NAR will be included in the nifi-assembly binary as well): - `io.prometheus:simpleclient` - `io.prometheus:simpleclient_hotspot` - `io.prometheus:simpleclient_servlet` - `org.eclipse.jetty` (multiple artifacts) - Java Servlet API In addition, it references artifacts I do not see as maven dependencies (though they could be transitively brought in... I haven't checked). The Jersey artifacts for example. Basically, this should match the dependencies defined in the pom.xml for the NAR, including transitive compile-scoped dependencies. You can use your IDE's maven features or maven commands such as `mvn dependency:tree` to help with this! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
