mcgilman commented on a change in pull request #3390: NIFI-6136 - fix: UI -
User and Template bug when page popped out
URL: https://github.com/apache/nifi/pull/3390#discussion_r272328634
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/templates/nf-templates.js
##########
@@ -95,9 +95,13 @@
if (clusterSummary.connectedToCluster) {
deferred.resolve(false);
} else {
- nfDialog.showDisconnectedFromClusterMessage(function
() {
+ if (clusterSummary.clustered) {
+
nfDialog.showDisconnectedFromClusterMessage(function () {
+ deferred.resolve(true);
+ });
+ } else {
deferred.resolve(true);
- });
+ }
Review comment:
The boolean that is resolved above should indicate if the user acknowledged
the node disconnection. In the else block, I think we should resolve with false
simply because we never prompted the user. From a functional standpoint, it may
not actually matter I don't think the flag is inspected when the instance is
not clustered. That said, it should try to keep the flag straight on the client
side. In the usage on the canvas, the value defaults to false and is only ever
updated once the connection state has changed.
This comment applies to the other change here as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
