alopresto commented on issue #3340: NIFI-6026 - First commit which adds a new 
tls-toolkit mode called Key…
URL: https://github.com/apache/nifi/pull/3340#issuecomment-481055148
 
 
   I ran through a series of manual tests on the toolkit mode. I like the 
functionality, and it works with both keystore formats. I made some comments 
requesting some unit test improvements and the removal of the "single hyphen" 
long argument in the CLI invocation. Once those are done, I will +1 and merge. 
Thanks. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to