arpadboda commented on a change in pull request #528: MINIFICPP-793: Allow SSL
Context to be defined from properties
URL: https://github.com/apache/nifi-minifi-cpp/pull/528#discussion_r273382395
##########
File path: extensions/http-curl/protocols/RESTSender.cpp
##########
@@ -99,11 +99,21 @@ const C2Payload RESTSender::sendPayload(const std::string
url, const Direction d
callback->ptr = input.get();
callback->pos = 0;
client.set_request_method("POST");
+ if (!ssl_context_service_) {
+ auto generatedService =
std::make_shared<minifi::controllers::SSLContextService>("Service",
configuration_);
Review comment:
Can we move the first two lines out of the direction branch to avoid
duplication?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
