granthenke commented on a change in pull request #3387: NIFI-6009 ScanKudu 
Processor & KuduPut Processor Delete Operation
URL: https://github.com/apache/nifi/pull/3387#discussion_r273567331
 
 

 ##########
 File path: 
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/kudu/PutKudu.java
 ##########
 @@ -131,8 +115,9 @@
     protected static final PropertyDescriptor INSERT_OPERATION = new Builder()
 
 Review comment:
   I am not sure the best way for Nifi to handle a change like this, but 
calling this `INSERT_OPERATION` while also supporting DELETE doesn't make a lot 
of sense. It should probably be something like `OPERATION_TYPE`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to