mcgilman commented on a change in pull request #3401: NIFI-6160 NIFI-6170 Apply
config error handling convention
URL: https://github.com/apache/nifi/pull/3401#discussion_r274108301
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-canvas-error-handler.js
##########
@@ -65,8 +65,20 @@
// shut off the auto refresh
nfCanvas.stopPolling();
- // allow page refresh with ctrl-r
+ // disable page refresh with ctrl-r
nfCanvas.disableRefreshHotKey();
+ },
Review comment:
While not introduced here, I believe there may be a bug with the
implementation of `handleAjaxError` here. Specifically, we only want to do
these actions when the handling of the ajax error resulted in hiding the
canvas. Wondering if we can simply return that fact from `handleAjaxError`?
That function is used directly in jQuery Deferred APIs. I don't see any issue
in their docs in doing this.
This issue will be more widespread now that more of the error handling will
be funneling through these functions and no longer handled inline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
