lfrancke commented on issue #3425: NIFI-6197 HBase: Fix deprecations, default 
for client retries & validations
URL: https://github.com/apache/nifi/pull/3425#issuecomment-482339547
 
 
   I can only provide anecdotes as well but I've now had two customers faces 
this issue in a short time which lead me to look into it. And we had good 
reasons to set this number to the current value in HBase :) In HBase 1.x the 
MTTR wasn't as good as it is now in 2.x so the retry count can be lowered in 
newer versions. Another good reason to not hardcode the default in NiFi, the 
defaults change the more we learn and work on the stability and MTTR.
   
   I don't fully understand the Javadoc on 
`AbstractConfigurableComponent#customValidate` but if it's only called after 
all properties have been set and the user clicked on Apply/Save then we could 
establish a connection (and tear it down again) there to validate whether the 
details are correct.
   
   Another option is to make a connection with retry = 1 in onEnabled and if 
that works tear it down and reconnect with the proper number. This will mean 
that enabling will take longer than before even if everything's good.
   
   If any of those is acceptable to you I'll work it into the patch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to