brosander edited a comment on issue #162: NIFIREG-238: Allow aliasing of registry url URL: https://github.com/apache/nifi-registry/pull/162#issuecomment-482594706 @kevdoran Thanks for the feedback, here are my thoughts around the suggestion. TL;DR - I'd prefer to keep this change as-is and evaluate all xml config files as part of a larger usability effort around all the JAX-B config but will make the change if we come to a consensus that it should be property-based instead. Rationale: I was concerned with adding a ton of extra properties to the nifi-registry.properties file and decided to follow convention for how other things seemed to be done. It could be implemented with properties but for my particular usecase [order of definition matters](https://github.com/apache/nifi-registry/pull/162#discussion_r269328710) and the properties will come in unordered. This would leave the user responsible for defining property names that sort alphabetically (or however we define the sorting logic) into the order they want their aliases in an upconvert case instead of a more natural list of properties. To be user friendly, I'd think we'd have to have actual numbers instead of names determine the order: ``` nifi.registry.alias.1.internal = INTERNAL_NIFI_REGISTRY_TOKEN nifi.registry.alias.1.external = https://my.new.secure.registry.url:18443 nifi.registry.alias.2.internal = http://my.old.insecure.registry.url:18080 nifi.registry.alias.2.external = https://my.new.secure.registry.url:18443 ``` If we still wanted to name them, we'd need either a convention property name (nifi.registry.alias.1.human_name.internal, nifi.registry.alias.1.human_name.external) or an additional property (nifi.registry.alias.1.name).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
