RynoRn commented on a change in pull request #13: [NIFI-6211] update nifi fds
dependencies
URL: https://github.com/apache/nifi-fds/pull/13#discussion_r276196089
##########
File path: src/platform/core/common/styles/_basicElements.scss
##########
@@ -19,56 +19,56 @@
font-family: 'Roboto';
font-style: normal;
font-weight: 300;
- src: local("Roboto Light"), local("Roboto-Light"),
url("../../../../../roboto-fontface/fonts/roboto/Roboto-Light.ttf")
format("truetype");
+ src: local("Roboto Light"), local("Roboto-Light"),
url("../../../../../roboto-fontface/fonts/roboto/Roboto-Light.woff2")
format("woff2");
Review comment:
I think it would make sense to expose these URL paths as a variable with a
`!default` value. That would give anyone the opportunity to override these
paths from outside.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
