arpadboda commented on a change in pull request #537: MINIFICPP-804 - C API 
Python examples are broken
URL: https://github.com/apache/nifi-minifi-cpp/pull/537#discussion_r276290249
 
 

 ##########
 File path: python/minifi/__init__.py
 ##########
 @@ -81,6 +81,9 @@ def get(self, session, context):
     def transfer(self, session, ff, rel):
         self._minifi.transfer(session, self._flow, rel.encode("UTF-8"))
 
 Review comment:
   Flow is the C flow structure (ExecutionPlan), which the C API was trying to 
get the flowfile from, but it doesn't really make sense in my opinion in case 
we already have the flowfile referenced here. 
   Naming: happy to rename, but I would prefer to have some suffix to avoid 
mixing transfer (relationship) and transmit (remote)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to