kevdoran commented on issue #169: NIFIREG-216 Add S3 BundlePersistenceProvider URL: https://github.com/apache/nifi-registry/pull/169#issuecomment-485459005 Hi @bbende, I like keeping it optional and structured as an extension. That gives us the most flexibility. I don't have a strong opinion the build profile being enabled by default or not. If we do want it enabled by default, I like doing it the way you propose in your comment above, If it is not enabled by default, I do think we should update the release instructions to explicitly enable it. My reasoning is that (1) I think it will be a popular feature, and (2) the docker image is usually built from the convenience binary, and I would like the S3 provider to be available in the `apache/nifi-registry` dockerhub image. Good point regarding the extension dir property. Is this an option: - nifi-registry.properties gets this added: nifi.registry.extension.dir.aws=${nifi.registry.extension.dir.aws} - when the AWS profile is active, that property gets set to `./ext/aws/lib` in the pom - when the AWS profile is not active, that property gets set to empty string in the pom - the code gets updated (if it is not already the case) to allow / ignore blank values for extension dir properties (perhaps logging to info or warn during startup to make it clear that no value was set?)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
