mcgilman commented on issue #3440: NIFI-6221 Adding 'Download' and 'View' 
content buttons to List Queue
URL: https://github.com/apache/nifi/pull/3440#issuecomment-485485167
 
 
   @patricker @aeaversa Sorry I may have jumped the gun. When I read through 
the comments and the changeset I thought it was being compared to the 
Provenance Details dialog where we show the View and Download buttons. The 
behavior of those buttons is what I outlined in my previous comments.
   
   Looking a bit closer at the queue listing I think everything is ok. The 
listing returns summaries. These summaries are returned as long as the user has 
permissions to the underlying queue. When attempting to download or view the 
content we authorize that specific data the same way we authorize the flowfile 
itself. So the introduction of the new buttons should fail in exactly the same 
circumstances as to when we access the flowfile details currently.
   
   @aeaversa Thanks for the PR!
   @patricker Thanks for the review!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to