aeaversa commented on issue #3440: NIFI-6221 Adding 'Download' and 'View' content buttons to List Queue URL: https://github.com/apache/nifi/pull/3440#issuecomment-485489999 @mcgilman @patricker - Thanks for the feedback! I definitely want to get this right. So when initially researched permissions in regard to adding the View/Download icons, I discovered that when I removed the 'View the Data' policy from a users accesses, the List Queue option in the canvas context menu actually provides an "Insufficient Permission" dialog when a user attempts to execute that function. Naturally, I assumed that meant an end user could never get to the List Queue dialog if they lacked appropriate accesses and subsequently never get to the Download/View buttons displayed under the "showDetails()" method within "nf-queue-listing.js". [1] [1] https://github.com/apache/nifi/blob/94c2b1e76ebab33b6417fb46ce046e59c51fcdca/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-queue-listing.js#L543 I do see the showDetails() method has the additional API call that returns a response with the "contentClaimContainer" property populated for the requested flow file, unless of course the file actually has no content associated with it (i.e. - 0 bytes), in which case it was not present. I do also see where this property is evaluated to hide/show the view/download buttons [2]. [2] https://github.com/apache/nifi/blob/94c2b1e76ebab33b6417fb46ce046e59c51fcdca/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-queue-listing.js#L598 So, I guess I am a little unclear how this is related to the provenance functionality you referenced? Are you indicating the that the "contentClaimContainer" property is additionally acting as a permissions based value that hide/showing those buttons when an end user is not authorized to see the content on "nf-queue-listing.js"? Am I correct in this understanding? My thanks again for all your help with this.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
