patricker commented on a change in pull request #2031: NIFI-617 - Message
destination option in MonitorActivity
URL: https://github.com/apache/nifi/pull/2031#discussion_r277694174
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/MonitorActivity.java
##########
@@ -248,13 +262,13 @@ public void onTrigger(final ProcessContext context,
final ProcessSession session
final boolean copyAttributes =
context.getProperty(COPY_ATTRIBUTES).asBoolean();
final boolean isClusterScope = isClusterScope(context, false);
final boolean shouldReportOnlyOnPrimary =
shouldReportOnlyOnPrimary(isClusterScope, context);
- final List<FlowFile> flowFiles = session.get(50);
+ final FlowFile flowFile = session.get();
Review comment:
Hi @pvillard31. I was reviewing this change (I rebased locally, had no
issues). The only concern I have is how you changed the code to read one
FlowFile at a time instead of batches. Functionally, I agree that this causes
no issues, but I wonder if it's the best approach? You could have looped
through the FlowFile's to update attributes, etc... when activity is restored.
I know it's been... a while since you wrote this. Can you recall your
motivations?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
