[ 
https://issues.apache.org/jira/browse/MINIFICPP-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829003#comment-16829003
 ] 

Daniel Bakai commented on MINIFICPP-828:
----------------------------------------

[~phrocker] I agree that it is a larger effort than just implementation ifdefs, 
mainly because we have to figure out how to create a good interface for it.

I don't think it is absolutely necessary to include this in 0.7.0, but if we 
don't, then we will have to duplicate some code from MINIFICPP-726 (This part, 
implementing the regex with both std::regex and regex.h: 
[https://github.com/apache/nifi-minifi-cpp/pull/533/files#diff-1366a475b82f862bc9b246f2a3d1a1ccR181]),
 because both GetSFTP and ListSFTP processors require them.

> Create a common regex utility 
> ------------------------------
>
>                 Key: MINIFICPP-828
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-828
>             Project: Apache NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Daniel Bakai
>            Assignee: Daniel Bakai
>            Priority: Major
>             Fix For: 0.8.0
>
>
> Multiple current and planned processors require regexes (see the linked 
> issues), so it would be practical to have a common regex implementation.
> Unfortunately we can't use std::regex everywhere, so we should create our own 
> interface and implement it in a common utility.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to