scottyaslan commented on a change in pull request #174: NIFIREG-256 Updating
manage buckets page
URL: https://github.com/apache/nifi-registry/pull/174#discussion_r280273705
##########
File path:
nifi-registry-core/nifi-registry-web-ui/src/main/webapp/components/administration/workflow/sidenav/manage-bucket/nf-registry-manage-bucket.html
##########
@@ -41,6 +41,20 @@
Save
</button>
</div>
+ <div class="pad-top-md pad-bottom-sm pad-left-md pad-right-md">
+ <div class="pad-bottom-sm">
+ <span class="md-card-title">Bundle Settings</span>
+ </div>
+ <div>
+ <mat-checkbox #bundleRedeployCheckbox
+
[disabled]="!nfRegistryService.currentUser.resourcePermissions.buckets.canWrite"
+
[(checked)]="nfRegistryService.bucket.allowBundleRedeploy"
+ [(ngModel)]="allowBundleRedeploy"
Review comment:
I found a slight bug in this PR. If you edit a bucket and check to "Allow
bundle overwrite" for said bucket... and then you click the 'X' in the top
right of the sidenav... and then you click the browser's back navigation
button... you will see that the checkbox selection is incorrect (it should be
checked at this point). To fix this please remove the
```[(checked)]="nfRegistryService.bucket.allowBundleRedeploy"```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
