scottyaslan commented on a change in pull request #17: [NIFI-6258] Updating
checkbox components to use the theme accent colors.
URL: https://github.com/apache/nifi-fds/pull/17#discussion_r280864068
##########
File path: src/platform/core/common/styles/_checkboxes.scss
##########
@@ -17,69 +17,84 @@
/* Checkboxes */
-body[fds] .mat-checkbox-inner-container {
- height: 10px !important;
- width: 10px !important;
-}
+@mixin fds-checkboxes-theme($theme) {
+ $primaryColor: map-get(map-get($theme, primary), 500);
+ $primaryColorHover: map-get(map-get($theme, primary), 100);
+ $accentColor: map-get(map-get($theme, accent), 500);
+ $accentColorHover: map-get(map-get($theme, accent), 100);
-body[fds] .mat-checkbox-frame {
- height: 10px;
- width: 10px;
- border-color: $grey7;
-}
+ body[fds] {
+ .mat-checkbox-inner-container {
+ height: 10px !important;
+ width: 10px !important;
+ margin-right: 5px;
-body[fds] .mat-checkbox-ripple {
- left: -7px;
- top: -7px;
- right: -7px;
- bottom: -7px;
-}
+ &:hover {
+ background-color: $accentColor;
+ border-radius: 2px;
+ }
+ }
-body[fds] .mat-checkbox-indeterminate.mat-accent .mat-checkbox-background,
-body[fds] .mat-checkbox-checked.mat-accent .mat-checkbox-background {
- background-color: $blue-grey1;
-}
+ .mat-checkbox-frame {
+ height: 10px;
+ width: 10px;
+ border-color: $grey7;
+ }
-body[fds] .mat-checkbox-inner-container:hover {
- background-color: $blue-grey1;
- border-radius: 2px;
-}
+ .mat-checkbox-ripple {
+ left: -19px;
+ top: -19px;
+ right: -7px;
+ bottom: -7px;
+ }
-body[fds] .mat-checkbox-background {
- height: 10px;
- width: 10px;
-}
+ .mat-checkbox-indeterminate.mat-accent .mat-checkbox-background,
+ .mat-checkbox-checked.mat-accent .mat-checkbox-background {
+ background-color: $accentColor;
+ }
-/* Covalent TdDataTableComponent 'selectable' property checkboxes */
+ .mat-checkbox-background {
+ height: 10px;
+ width: 10px;
+ }
-body[fds] .mat-pseudo-checkbox {
- height: 10px !important;
- width: 10px !important;
- border: 1px solid $grey7;
-}
+ /* Covalent TdDataTableComponent 'selectable' property checkboxes */
-body[fds] .mat-pseudo-checkbox:hover {
- background-color: $blue-grey1;
- border: 1px solid $blue-grey1;
-}
+ .mat-pseudo-checkbox {
+ height: 10px !important;
+ width: 10px !important;
+ border: 1px solid $grey7;
+ }
-body[fds] .mat-pseudo-checkbox-checked::after {
- content: '\f00c';
- font-size: 8px;
- font-family: fontawesome;
- margin-top: -9px;
- margin-left: -1px;
- border: none;
- transform: initial;
-}
+ .mat-pseudo-checkbox:hover {
Review comment:
Please delete this style it is not used in nifi-fds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
