scottyaslan commented on a change in pull request #15: [NIFI-6237] - styling for td-chips text input component (no text over… URL: https://github.com/apache/nifi-fds/pull/15#discussion_r281269684
########## File path: src/platform/core/common/styles/_td-chips.scss ########## @@ -0,0 +1,42 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or more +* contributor license agreements. See the NOTICE file distributed with +* this work for additional information regarding copyright ownership. +* The ASF licenses this file to You under the Apache License, Version 2.0 +* (the "License"); you may not use this file except in compliance with +* the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +body[fds] td-chips .mat-input-placeholder-wrapper::after { + content: '\f0b0'; + display: inline-table; + font-family: FontAwesome; + float: right; + margin: 13px 10px 0px 0px; + color: $grey3; +} + +body[fds] td-chips { + input.mat-input-element, + textarea.mat-input-element { + /* subtract 42 (10 for padding-left, 30 for padding right, 2 the 1px border of the input on the left & right) */ + width: calc(100% - 42px); // account for padding and border as to line up with the underline + padding-right: 30px; // Don't allow the text to overlap the filter icon + } +} + +body[fds] .td-chip span { + font-size: 10px; +} + +body [fds] mat-form-field.td-chips-form-field.mat-input-container { Review comment: Please delete this whole rule... you had a space in between body and [fds] so the rule was not applying correctly which caused me to look at this and determine we just want to remove the width for all inputs... I placed a comment on your input PR as well... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
