arpadboda commented on a change in pull request #550: MINIFICPP-822 - Nanofi raw S2S implementation shouldn't depend on any… URL: https://github.com/apache/nifi-minifi-cpp/pull/550#discussion_r281609889
########## File path: libminifi/test/RandomServerSocket.cpp ########## @@ -0,0 +1,58 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "./RandomServerSocket.h" + +#include <sstream> +#include <random> +#include <string> +#include <memory> + +#include "core/logging/Logger.h" +#include "core/logging/LoggerConfiguration.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace io { + + RandomServerSocket::RandomServerSocket(const std::string& host, uint16_t offset, uint16_t range, uint16_t retries) : + ServerSocket::ServerSocket(std::make_shared<org::apache::nifi::minifi::io::SocketContext>(std::make_shared<minifi::Configure>()), host, 0, 1) { + std::random_device rd; + std::mt19937 gen(rd()); + std::uniform_int_distribution<uint16_t> dis(offset, offset + range); Review comment: As it's a test code I highly hope noone is so dumb to try to generate a port over uint16_t::max, but I can make it bulletproof if you prefer to have that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
