arpadboda commented on a change in pull request #553: MINIFICPP-287: Add
property for flow files to log
URL: https://github.com/apache/nifi-minifi-cpp/pull/553#discussion_r284195052
##########
File path: extensions/standard-processors/processors/LogAttribute.cpp
##########
@@ -39,12 +39,14 @@ namespace nifi {
namespace minifi {
namespace processors {
-core::Property
LogAttribute::LogLevel(core::PropertyBuilder::createProperty("Log
Level")->withDescription("The Log Level to use when logging the
Attributes")->withAllowableValues<std::string>({
+core::Property
LogAttribute::LogLevel(core::PropertyBuilder::createProperty("Log
Level")->withDescription("The Log Level to use when logging the
Attributes")->withAllowableValues<std::string>( {
"info", "trace", "error", "warn", "debug" })->build());
core::Property LogAttribute::AttributesToLog(
core::PropertyBuilder::createProperty("Attributes to
Log")->withDescription("A comma-separated list of Attributes to Log. If not
specified, all attributes will be logged.")->build());
+core::Property
LogAttribute::FlowFilesToLog(core::PropertyBuilder::createProperty("FlowFiles
To Log")->withDescription("Number of flow files to
log")->withDefaultValue<int>(1)->build());
Review comment:
Why not uint?
We have unsigned validator, too.
That would prevent negative and 0 could mean "log as many as available in
the session".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
