bakaid commented on a change in pull request #550: MINIFICPP-822 - Nanofi raw 
S2S implementation shouldn't depend on any…
URL: https://github.com/apache/nifi-minifi-cpp/pull/550#discussion_r284223148
 
 

 ##########
 File path: nanofi/tests/CSite2SiteTests.cpp
 ##########
 @@ -18,31 +18,59 @@
 
 #include <stdlib.h>
 
-#include <uuid/uuid.h>
 #include <algorithm>
+#include <chrono>
 #include <string>
 #include <memory>
 #include <utility>
 #include <map>
+#include <thread>
+
 #include "io/BaseStream.h"
 #include "TestBase.h"
 #include "unit/SiteToSiteHelper.h"
 #include "sitetosite/CPeer.h"
 #include "sitetosite/CRawSocketProtocol.h"
 #include "sitetosite/CSiteToSite.h"
-#include <algorithm>
-#include <core/cxxstructs.h>
+#include "sitetosite/RawSocketProtocol.h"
+#include "uuid/uuid.h"
+#include "core/cstructs.h"
+#include "RandomServerSocket.h"
+#include "core/log.h"
 
 #define FMT_DEFAULT fmt_lower
 
-TEST_CASE("TestSetPortId", "[S2S1]") {
-  auto stream_ptr = std::unique_ptr<minifi::io::BaseStream>(new 
org::apache::nifi::minifi::io::BaseStream());
-
-  cstream cstrm;
-  cstrm.impl = stream_ptr.get();
+const char * ATTR_NAME = "some_key";
+const char * ATTR_VALUE = "some value";
+const char * PAYLOAD = "Test MiNiFi payload";
+const char * PAYLOAD_CRC = "2006463717"; // Depends on both payload and 
attributes, do NOT change manually!
+std::string CODEC_NAME = "StandardFlowFileCodec";
+
+struct S2SReceivedData {
+  bool request_type_ok;
 
 Review comment:
   This is potentially uninitialized.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to