arpadboda commented on a change in pull request #554: MINIFICPP-842 - CivetWeb 
tests should use random port
URL: https://github.com/apache/nifi-minifi-cpp/pull/554#discussion_r284259782
 
 

 ##########
 File path: extensions/civetweb/processors/ListenHTTP.cpp
 ##########
 @@ -27,11 +27,22 @@ namespace minifi {
 namespace processors {
 
 core::Property ListenHTTP::BasePath(
-    core::PropertyBuilder::createProperty("Base Path")->withDescription("Base 
path for incoming 
connections")->isRequired(false)->withDefaultValue<std::string>("contentListener")->build());
+    core::PropertyBuilder::createProperty("Base Path")->
 
 Review comment:
   That's a good point, thanks!
   Checked other processors, it should be the opposite way ( -> operator is at 
the beginning of new lines) to be linter-compatible, so fixed. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to