phrocker commented on a change in pull request #554: MINIFICPP-842 - CivetWeb 
tests should use random port
URL: https://github.com/apache/nifi-minifi-cpp/pull/554#discussion_r284412208
 
 

 ##########
 File path: extensions/civetweb/processors/ListenHTTP.cpp
 ##########
 @@ -40,12 +51,18 @@ core::Property ListenHTTP::SSLCertificate("SSL 
Certificate", "File containing PE
 core::Property ListenHTTP::SSLCertificateAuthority("SSL Certificate 
Authority", "File containing trusted PEM-formatted certificates", "");
 
 core::Property ListenHTTP::SSLVerifyPeer(
-    core::PropertyBuilder::createProperty("SSL Verify 
Peer")->withDescription("Whether or not to verify the client's certificate 
(yes/no)")->isRequired(false)->withAllowableValue<std::string>("yes")
-        ->withAllowableValue("no")->withDefaultValue("no")->build());
+    core::PropertyBuilder::createProperty("SSL Verify Peer")->
+    withDescription("Whether or not to verify the client's certificate 
(yes/no)")->
 
 Review comment:
   That is a fluent API fyi

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to