alopresto commented on a change in pull request #3482: NIFI-6280 - Broke out
the matching for /access/knox/** and /access/oi…
URL: https://github.com/apache/nifi/pull/3482#discussion_r285300417
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/NiFiAuthenticationFilter.java
##########
@@ -107,16 +107,16 @@ private void authenticate(final HttpServletRequest
request, final HttpServletRes
*/
public abstract Authentication attemptAuthentication(HttpServletRequest
request);
- protected void successfulAuthorization(HttpServletRequest request,
HttpServletResponse response, Authentication authResult) {
+ protected void successfulAuthentication(HttpServletRequest request,
HttpServletResponse response, Authentication authResult) {
Review comment:
I think it would be helpful to add Javadoc to these methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
