arpadboda commented on a change in pull request #557: MINIFICPP-850: Add
operating system to c2 response
URL: https://github.com/apache/nifi-minifi-cpp/pull/557#discussion_r285487608
##########
File path: libminifi/include/core/state/nodes/DeviceInformation.h
##########
@@ -113,59 +113,59 @@ class Device {
std::string device_id_;
protected:
- std::vector<std::string> getIpAddresses() {
- static std::vector<std::string> ips;
- if (ips.empty()) {
+ std::vector<std::string> getIpAddresses() {
+ static std::vector<std::string> ips;
Review comment:
Not sure if it's meant to be thread-safe or not.
In case it is, the code below inside the condition should be moved to a util
function and static init does the rest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
