bakaid commented on a change in pull request #558: MINIFICPP-542 - Add PutSFTP processor URL: https://github.com/apache/nifi-minifi-cpp/pull/558#discussion_r285530879
########## File path: thirdparty/libssh2/include/libssh2_publickey.h ########## @@ -0,0 +1,119 @@ +/* Copyright (c) 2004-2006, Sara Golemon <[email protected]> Review comment: The include directory is copied verbatim from the same version we use in the ExternalProject. I've seen this done with all of our thirdparty dependencies, and I suspected that this is because we don't want to depend on includes only available in the build directory after building the external project. If this is not the case, I will revise this. The patch file and the copied CMakeLists.txt, which are applied in the PATCH phase are my own modifications (on Windows we don't have a patch command, so the modified CMakeLists.txt is copied over the one in the downloaded sources). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
