archongum commented on a change in pull request #3481: NIFI-6305: RecordPath 
Standalone Functions: format() and toDate() allow time zone argument
URL: https://github.com/apache/nifi/pull/3481#discussion_r285784805
 
 

 ##########
 File path: nifi-commons/nifi-record-path/pom.xml
 ##########
 @@ -66,6 +66,11 @@
             <artifactId>nifi-record</artifactId>
             <version>1.10.0-SNAPSHOT</version>
         </dependency>
+        <dependency>
+            <groupId>org.apache.nifi</groupId>
+            <artifactId>nifi-properties</artifactId>
 
 Review comment:
   `StringUtils.isEmpty()` is in this dependency. At my first commit, I used 
`str == null || str.isEmpty()` but Mike suggests to use `StringUtils.isEmpty()` 
instead and `nifi-record-path` hasn't, has it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to