[
https://issues.apache.org/jira/browse/NIFI-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-6296:
--------------------------------
Resolution: Fixed
Fix Version/s: 1.10.0
Status: Resolved (was: Patch Available)
> Improve instructions on submitting PR commits
> ---------------------------------------------
>
> Key: NIFI-6296
> URL: https://issues.apache.org/jira/browse/NIFI-6296
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Documentation & Website
> Affects Versions: 1.9.2
> Reporter: Andy LoPresto
> Assignee: Andy LoPresto
> Priority: Minor
> Labels: documentation
> Fix For: 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Some contributors have been confused about how to provide additional commits
> when a PR reviewer asks for changes because the Contributor Guide and PR
> template emphasize a "single, squashed commit".
> I'll update these documents to explain that the _initial_ commit should be a
> single, squashed commit, but additional changes should be made on the same
> branch and pushed (without force pushing/overwriting) so the reviewers can
> see the changes. The eventual committer will squash and rebase (unless this
> is non-trivial, in which case they can ask the author to perform this task).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
