MikeThomsen commented on a change in pull request #3257: NIFI-5435 Prometheus 
/metrics http endpoint for monitoring integration
URL: https://github.com/apache/nifi/pull/3257#discussion_r287802863
 
 

 ##########
 File path: 
nifi-nar-bundles/nifi-prometheus-bundle/nifi-prometheus-nar/src/main/resources/META-INF/NOTICE
 ##########
 @@ -0,0 +1,44 @@
+Copyright 2015-2017 The Apache Software Foundation
 
 Review comment:
   What I do is use `mvn dependency:tree | grep compile` on the NAR project and 
hunt through existing NOTICE and LICENSE files for existing verbiage that can 
be applied. Virtually everything you have there is already in an existing 
NOTICE or LICENSE file. For the NiFi ones, you can skip references to those. 
Everything else, I'd recommend you copy and paste from existing files. As far 
as I can tell, the organization for Prometheus dependencies would be the Linux 
Foundation since that is what their site asserts viz a viz the copyright notice.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to