[
https://issues.apache.org/jira/browse/NIFI-6331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852118#comment-16852118
]
Andy LoPresto edited comment on NIFI-6331 at 5/30/19 6:30 PM:
--------------------------------------------------------------
After reviewing the code where this is located, I am proposing removing the
module entirely for the following reasons:
* The tests do not run by default (there is a {{skip-testharness-tests}}
profile activated by default)
* When the tests are run (using the {{run-testharness-tests}} profile), they
fail)
* There is a mock {{$NIFI_HOME}} directory at the module root alongside {{src}}
and {{target}}; this should be in {{target}}
* There were copyright issues [noted on the original
PR|https://github.com/apache/nifi/pull/3165#discussion_r236045703] introducing
this feature, but the non-Apache resource is still used
* There is no documentation on how to use it or get the tests passing
I propose removing this module from NiFi and encouraging the contributor to
maintain it in a separate repository for interested users.
was (Author: alopresto):
After reviewing the code where this is located, I am proposing removing the
module entirely for the following reasons:
* The tests do not run by default (there is a {{skip-testharness-tests}}
profile activated by default
* When the tests are run (using the {{run-testharness-tests}} profile), they
fail
* There is a mock {{$NIFI_HOME}} directory at the module root alongside {{src}}
and {{target}}; this should be in {{target}}
* There were copyright issues [noted on the original
PR|https://github.com/apache/nifi/pull/3165#discussion_r236045703] introducing
this feature, but the non-Apache resource is still used
* There is no documentation on how to use it or get the tests passing
I propose removing this module from NiFi and encouraging the contributor to
maintain it in a separate repository for interested users.
> Remove dependency on external (non-Apache) HTTP resource for data feed
> ----------------------------------------------------------------------
>
> Key: NIFI-6331
> URL: https://issues.apache.org/jira/browse/NIFI-6331
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
> Affects Versions: 1.9.2
> Reporter: Andy LoPresto
> Assignee: Andy LoPresto
> Priority: Major
> Labels: resource, test
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A test resource
> (https://github.com/apache/nifi/blob/master/nifi-testharness/src/test/resources/flow.xml#L85-L91)
> uses the BBC World RSS feed in a {{GetHTTP}} processor. This RSS feed is
> served over HTTP. I believe we should not rely on external (non-Apache)
> hosted services for tests, as these could change at any time, and regardless
> of the origin of the data, should prefer HTTPS unless explicitly testing HTTP
> services.
> I propose changing the test resource to use
> {{https://nifi.apache.org/security.html}} or any other page hosted on the
> NiFi site (the test flow functionality does not use any RSS features).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
