arpadboda commented on a change in pull request #577: MINIFICPP-904: Switch to
get_separator() in MiNiFi Main
URL: https://github.com/apache/nifi-minifi-cpp/pull/577#discussion_r289402733
##########
File path: main/Main.h
##########
@@ -128,7 +123,7 @@ extern "C" {
bool validHome(const std::string &home_path) {
struct stat stat_result { };
std::string sep;
- sep += FILE_SEPARATOR;
+ sep += utils::file::FileUtils::get_separator();
Review comment:
why +=? The variable simply could be initialized with the return value of
the function.
Moreover, looking at the code below, I would prefer removing the WIN32
ifdef, too, and removing the leading separator from this line:
```
#define DEFAULT_NIFI_PROPERTIES_FILE "\\conf\\minifi.properties"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
