bbende edited a comment on issue #3488: NIFI-6315 Ensuring remote ports get tracked correctly when saving/ret… URL: https://github.com/apache/nifi/pull/3488#issuecomment-497726801 @ijokarumawak great catch! There is actually two parts to that problem... 1) NiFi side was not setting concurrent tasks on Port based on proposed VersionedPort. This was because previously all ports were local and could never have tasks > 1. This part I addressed with a new commit. 2) The flow comparison does not trigger a local change when changing the value of concurrent tasks on a public port. This part is based on the FlowComparator which comes from NiFi Registry code. I created this JIRA and will put up a PR later - https://issues.apache.org/jira/browse/NIFIREG-276 For the time being it just means the change to concurrent tasks will be captured with the next change to the PG. If you agree then we should be good to merge this one. Feel free to squash the commits, I only left them separate to make it easier to understand each change while reviewing.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
