bbende commented on a change in pull request #194: NIFIREG-212 Separating proxy
into Read, Write, and Delete so some pro…
URL: https://github.com/apache/nifi-registry/pull/194#discussion_r289541083
##########
File path:
nifi-registry-core/nifi-registry-security-api/src/main/java/org/apache/nifi/registry/security/authentication/AuthenticationRequest.java
##########
@@ -17,17 +17,20 @@
package org.apache.nifi.registry.security.authentication;
import java.io.Serializable;
+import java.util.Objects;
public class AuthenticationRequest implements Serializable {
private String username;
private Object credentials;
private Object details;
+ private String httpMethod;
- public AuthenticationRequest(String username, Object credentials, Object
details) {
+ public AuthenticationRequest(String username, Object credentials, Object
details, String httpMethod) {
Review comment:
Makes sense, now that I understand how the details object is being used I
definitely agree that would be the better approach. Will work on updating that.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
