FrederikP commented on issue #3500: NIFI-6322: Reuse evaluator stored in 
CompiledExpression when creating a query.
URL: https://github.com/apache/nifi/pull/3500#issuecomment-498210524
 
 
   I added some test cases covering the issues with selecting and reducing 
functions in 2ffd167.
   
   In e1bc939 I then added reset functions to the corresponding evaluators 
allowing reusage of the whole evaluator tree in prepared queries. All tests are 
green with those changes.
   It's different than what you have done in #3277. Haven't really worked 
through that PR in detail yet, but I wanted to understand the underlying issue, 
so I spent some time on the latest commits. Feel free to let me know what you 
think.
   
   If my changes aren't needed it's probably a good idea to merge the test 
cases from 2ffd167 as they cover some branches that weren't covered before.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to