arpadboda commented on issue #573: minificpp-873 Implmented.
URL: https://github.com/apache/nifi-minifi-cpp/pull/573#issuecomment-498231105
 
 
   > @msharee9 @bakaid @arpadboda I see some minor comments at this point. Are 
all major issues addressed? If so can we +1 and merge? Thanks!
   
   @phrocker : my main concern was storing the properties as global static, so 
only one instance of the given processor can be instantiated without messing 
things up. @am-c-p-p  marked it as resolved, but nor I see related changes, 
neither a reply to prove me wrong (maybe I missed something), so I would prefer 
to have that concern of mine resolved before merging. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to