FrederikP edited a comment on issue #3500: NIFI-6322: Reuse evaluator stored in CompiledExpression when creating a query. URL: https://github.com/apache/nifi/pull/3500#issuecomment-498267539 My latest changes revert some of the reducing/selecting specific code from my earlier changes and replace it with a more generic cleanup default method in the evaluator interface that is implemented for all stateful evaluators. This is then called in the CompiledExpression after an evaluation to cleanup for the next call. The tests are green and this change also works for And + Or evaluators. It should also make the diff less complex. Edit: I noticed that I forgot to include the jira issue number in the commit message for the last two commits. If this will be merged into nifi at some point, I will gladly recommit these changes as one or two (tests extra) commits
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
