alopresto commented on a change in pull request #3495: NIFI-5973 Adds ShellUserGroupProvider URL: https://github.com/apache/nifi/pull/3495#discussion_r290560441
########## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-shell-authorizer/src/main/java/org/apache/nifi/authorization/NssShellCommands.java ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.authorization; + +class NssShellCommands implements ShellCommandsProvider { + public String getUsersList() { Review comment: Also commenting on the `ShellCommandsProvider` interface, but I think each implementation should have generic behavior documented in class-level Javadoc, as well as each method commented with what the expected format of the response is (the format should be common across all providers; the method in which each impl achieves that would be OS-specific). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
