kevdoran commented on issue #519: MINIFICPP-783: Fix bootstrap curl install on Darwin URL: https://github.com/apache/nifi-minifi-cpp/pull/519#issuecomment-499183451 @phrocker I wanted to revisit this even though it was already merged. I was setting up a new Mac machine recently and came across a few surprises with Homebrew formulas that used to work for me failing to run, in a similar manner to the one that was changed here. In looking into it, I came across this: https://github.com/Homebrew/homebrew-core/issues/31510 Apparently, options that used to trigger installing from source with certain dependencies are being (have been?) removed from most/all formulas in homebrew-core. So the change in this PR is installing curl linked to Darwin's secure transport SSL lib. For example: ``` curl 7.65.1 (x86_64-apple-darwin18.6.0) libcurl/7.65.1 SecureTransport zlib/1.2.11 Release-Date: 2019-06-05 Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp smb smbs smtp smtps telnet tftp Features: AsynchDNS IPv6 Largefile libz NTLM NTLM_WB SSL UnixSockets ``` Is that what we want? It might be fine, but just wanted to bring it up as I'm not sure if that was the intention. If we want to continue to prefer openssl on darwin, we may want to switch formulas or move to a different tap other than homebrew-core. On my machine I'm now using `curl-openssl`, which provides this: ``` /usr/local/Cellar/curl-openssl/7.65.0/bin/curl --version curl 7.65.0 (x86_64-apple-darwin18.6.0) libcurl/7.65.0 OpenSSL/1.0.2r zlib/1.2.11 brotli/1.0.7 c-ares/1.15.0 libssh2/1.8.2 nghttp2/1.38.0 librtmp/2.3 Release-Date: 2019-05-22 Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtmp rtsp scp sftp smb smbs smtp smtps telnet tftp Features: AsynchDNS brotli GSS-API HTTP2 HTTPS-proxy IPv6 Kerberos Largefile libz Metalink NTLM NTLM_WB SPNEGO SSL TLS-SRP UnixSockets ``` Anyway, just wanted to bring this up. Let me know what you think. I can do additional testing if needed.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
