kevdoran commented on issue #3492: NIFI-6164 - Added CLI commands related to NiFi Registry extension bun… URL: https://github.com/apache/nifi/pull/3492#issuecomment-501756102 @bbende Thanks for the detailed explanation. This all makes a lot more sense now. - On the first point, Let's leave it as bucketName for now, but I would open up a Jira to make either command (flows or bundles) work with either name or id. For flows, if a name is given, we can make the CLI get buckets, find the matching id, and then call the existing endpoint with an ID param. For bundles, if an ID is given, we can do the same call to get buckets in order to lookup the name, and then continue as it works today. We could probably make this easier by adding some lookup methods to the NiFiRegistryClient that wraps the API to perform bucket lookup by name or id. - On the second point, I feel like the current implementation method (drilling into group, artifact, version) is optimized for interactive shell use, whereas the other method we are discussing (listing all bundles) would be optimized for scripting automation use. Just thinking that if I were scripting calls to the CLI and needed all bundles, it would be tedious to write three nested for loops that uses the results of each "level" to make another call. I see both sides though - a huge table of results in the interactive shell might not be as useable as the current way you have it. - I think we are on the same page with the last two points. Thanks for all the hard work on this feature. From the backend through the REST API and client and now CLI, it's a very complete implementation!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
