alopresto commented on a change in pull request #3495: NIFI-5973 Adds ShellUserGroupProvider URL: https://github.com/apache/nifi/pull/3495#discussion_r293605220
########## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-shell-authorizer/src/main/java/org/apache/nifi/authorization/ShellCommandsProvider.java ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.authorization; + +/** + * Common interface for shell command strings to read users and groups. + * + */ +interface ShellCommandsProvider { + /** + * Gets the command for listing users. + * + * When executed, this command should output one record per line in this format: + * + * `username:user-id:primary-group-id` + * + * @return Shell command string that will return a list of users. + */ + String getUsersList(); + + /** + * Gets the command for listing the group membership of a user. + * + * When executed, this command should output one line in this format: + * + * `group-name-1,group-name-2,group-name-n` + * + * @return Shell command string that will return a list of groups for a user. + */ + String getUserGroups(); + + /** + * Gets the command for listing groups. + * + * When executed, this command should output one record per line in this format: + * + * `group-name:group-id` + * + * @return Shell command string that will return a list of groups. + */ + String getGroupsList(); + + /** + * Gets the command for listing the members of a group. + * + * When executed, this command should output one line in this format: + * + * `user-name-1,user-name-2,user-name-n` + * + * @return Shell command string that will return a list of users for a group. + * @param groupName name of group. Review comment: Same Javadoc element ordering comment as above. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
