jtstorck commented on a change in pull request #3520: NIFI-5373 Created new 
module nifi-metrics
URL: https://github.com/apache/nifi/pull/3520#discussion_r294433092
 
 

 ##########
 File path: 
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-0-11-nar/src/main/resources/META-INF/NOTICE
 ##########
 @@ -45,6 +45,20 @@ The following binary components are provided under the 
Apache Software License v
       Apache Kafka
       Copyright 2012 The Apache Software Foundation.
 
+  (ASLv2) Yammer Metrics
 
 Review comment:
   I'll remove Yammer Metrics from the NOTICE files for the 0-9, 0-10, 0-11, 
1-0, and 2-0 NARs.  After a second look, I see that the `kafka_2.x` 
dependencies are `test`-scoped.
   Output of `mvn dependency:tree "-Dincludes=:*metrics*::"`:
   ```
   [INFO] Scanning for projects...
   [INFO] Inspecting build with total of 13 modules...
   [INFO] Installing Nexus Staging features:
   [INFO]   ... total of 13 executions of maven-deploy-plugin replaced with 
nexus-staging-maven-plugin
   [INFO] 
------------------------------------------------------------------------
   [INFO] Reactor Build Order:
   [INFO]
   [INFO] nifi-kafka-bundle                                                  
[pom]
   [INFO] nifi-kafka-0-8-processors                                          
[jar]
   [INFO] nifi-kafka-0-9-processors                                          
[jar]
   [INFO] nifi-kafka-0-10-processors                                         
[jar]
   [INFO] nifi-kafka-0-11-processors                                         
[jar]
   [INFO] nifi-kafka-1-0-processors                                          
[jar]
   [INFO] nifi-kafka-2-0-processors                                          
[jar]
   [INFO] nifi-kafka-0-8-nar                                                 
[nar]
   [INFO] nifi-kafka-0-9-nar                                                 
[nar]
   [INFO] nifi-kafka-0-10-nar                                                
[nar]
   [INFO] nifi-kafka-0-11-nar                                                
[nar]
   [INFO] nifi-kafka-1-0-nar                                                 
[nar]
   [INFO] nifi-kafka-2-0-nar                                                 
[nar]
   [INFO]
   [INFO] -----------------< org.apache.nifi:nifi-kafka-bundle 
>------------------
   [INFO] Building nifi-kafka-bundle 1.10.0-SNAPSHOT                        
[1/13]
   [INFO] --------------------------------[ pom 
]---------------------------------
   [INFO]
   [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ 
nifi-kafka-bundle ---
   [INFO]
   [INFO] -------------< org.apache.nifi:nifi-kafka-0-8-processors 
>--------------
   [INFO] Building nifi-kafka-0-8-processors 1.10.0-SNAPSHOT                
[2/13]
   [INFO] --------------------------------[ jar 
]---------------------------------
   [INFO]
   [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ 
nifi-kafka-0-8-processors ---
   [INFO] org.apache.nifi:nifi-kafka-0-8-processors:jar:1.10.0-SNAPSHOT
   [INFO] \- org.apache.kafka:kafka_2.10:jar:0.8.2.2:compile
   [INFO]    \- com.yammer.metrics:metrics-core:jar:2.2.0:compile
   [INFO]
   [INFO] -------------< org.apache.nifi:nifi-kafka-0-9-processors 
>--------------
   [INFO] Building nifi-kafka-0-9-processors 1.10.0-SNAPSHOT                
[3/13]
   [INFO] --------------------------------[ jar 
]---------------------------------
   [INFO]
   [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ 
nifi-kafka-0-9-processors ---
   [INFO] org.apache.nifi:nifi-kafka-0-9-processors:jar:1.10.0-SNAPSHOT
   [INFO] \- org.apache.kafka:kafka_2.10:jar:0.9.0.1:test
   [INFO]    \- com.yammer.metrics:metrics-core:jar:2.2.0:test
   [INFO]
   [INFO] -------------< org.apache.nifi:nifi-kafka-0-10-processors 
>-------------
   [INFO] Building nifi-kafka-0-10-processors 1.10.0-SNAPSHOT               
[4/13]
   [INFO] --------------------------------[ jar 
]---------------------------------
   [INFO]
   [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ 
nifi-kafka-0-10-processors ---
   [INFO] org.apache.nifi:nifi-kafka-0-10-processors:jar:1.10.0-SNAPSHOT
   [INFO] \- org.apache.kafka:kafka_2.10:jar:0.10.2.2:test
   [INFO]    \- com.yammer.metrics:metrics-core:jar:2.2.0:test
   [INFO]
   [INFO] -------------< org.apache.nifi:nifi-kafka-0-11-processors 
>-------------
   [INFO] Building nifi-kafka-0-11-processors 1.10.0-SNAPSHOT               
[5/13]
   [INFO] --------------------------------[ jar 
]---------------------------------
   [INFO]
   [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ 
nifi-kafka-0-11-processors ---
   [INFO] org.apache.nifi:nifi-kafka-0-11-processors:jar:1.10.0-SNAPSHOT
   [INFO] \- org.apache.kafka:kafka_2.11:jar:0.11.0.3:test
   [INFO]    \- com.yammer.metrics:metrics-core:jar:2.2.0:test
   [INFO]
   [INFO] -------------< org.apache.nifi:nifi-kafka-1-0-processors 
>--------------
   [INFO] Building nifi-kafka-1-0-processors 1.10.0-SNAPSHOT                
[6/13]
   [INFO] --------------------------------[ jar 
]---------------------------------
   [INFO]
   [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ 
nifi-kafka-1-0-processors ---
   [INFO] org.apache.nifi:nifi-kafka-1-0-processors:jar:1.10.0-SNAPSHOT
   [INFO] \- org.apache.kafka:kafka_2.11:jar:1.0.2:test
   [INFO]    \- com.yammer.metrics:metrics-core:jar:2.2.0:test
   [INFO]
   [INFO] -------------< org.apache.nifi:nifi-kafka-2-0-processors 
>--------------
   [INFO] Building nifi-kafka-2-0-processors 1.10.0-SNAPSHOT                
[7/13]
   [INFO] --------------------------------[ jar 
]---------------------------------
   [INFO]
   [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ 
nifi-kafka-2-0-processors ---
   [INFO] org.apache.nifi:nifi-kafka-2-0-processors:jar:1.10.0-SNAPSHOT
   [INFO] \- org.apache.kafka:kafka_2.11:jar:2.0.0:test
   [INFO]    \- com.yammer.metrics:metrics-core:jar:2.2.0:test
   [INFO]
   [INFO] -----------------< org.apache.nifi:nifi-kafka-0-8-nar 
>-----------------
   [INFO] Building nifi-kafka-0-8-nar 1.10.0-SNAPSHOT                       
[8/13]
   [INFO] --------------------------------[ nar 
]---------------------------------
   [INFO]
   [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ 
nifi-kafka-0-8-nar ---
   [INFO] org.apache.nifi:nifi-kafka-0-8-nar:nar:1.10.0-SNAPSHOT
   [INFO] \- 
org.apache.nifi:nifi-kafka-0-8-processors:jar:1.10.0-SNAPSHOT:compile
   [INFO]    \- org.apache.kafka:kafka_2.10:jar:0.8.2.2:compile
   [INFO]       \- com.yammer.metrics:metrics-core:jar:2.2.0:compile
   [INFO]
   [INFO] -----------------< org.apache.nifi:nifi-kafka-0-9-nar 
>-----------------
   [INFO] Building nifi-kafka-0-9-nar 1.10.0-SNAPSHOT                       
[9/13]
   [INFO] --------------------------------[ nar 
]---------------------------------
   [INFO]
   [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ 
nifi-kafka-0-9-nar ---
   [INFO]
   [INFO] ----------------< org.apache.nifi:nifi-kafka-0-10-nar 
>-----------------
   [INFO] Building nifi-kafka-0-10-nar 1.10.0-SNAPSHOT                     
[10/13]
   [INFO] --------------------------------[ nar 
]---------------------------------
   [INFO]
   [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ 
nifi-kafka-0-10-nar ---
   [INFO]
   [INFO] ----------------< org.apache.nifi:nifi-kafka-0-11-nar 
>-----------------
   [INFO] Building nifi-kafka-0-11-nar 1.10.0-SNAPSHOT                     
[11/13]
   [INFO] --------------------------------[ nar 
]---------------------------------
   [INFO]
   [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ 
nifi-kafka-0-11-nar ---
   [INFO]
   [INFO] -----------------< org.apache.nifi:nifi-kafka-1-0-nar 
>-----------------
   [INFO] Building nifi-kafka-1-0-nar 1.10.0-SNAPSHOT                      
[12/13]
   [INFO] --------------------------------[ nar 
]---------------------------------
   [INFO]
   [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ 
nifi-kafka-1-0-nar ---
   [INFO]
   [INFO] -----------------< org.apache.nifi:nifi-kafka-2-0-nar 
>-----------------
   [INFO] Building nifi-kafka-2-0-nar 1.10.0-SNAPSHOT                      
[13/13]
   [INFO] --------------------------------[ nar 
]---------------------------------
   [INFO]
   [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ 
nifi-kafka-2-0-nar ---
   [INFO] 
------------------------------------------------------------------------
   [INFO] Reactor Summary for nifi-kafka-bundle 1.10.0-SNAPSHOT:
   [INFO]
   [INFO] nifi-kafka-bundle .................................. SUCCESS [  0.289 
s]
   [INFO] nifi-kafka-0-8-processors .......................... SUCCESS [  0.201 
s]
   [INFO] nifi-kafka-0-9-processors .......................... SUCCESS [  0.040 
s]
   [INFO] nifi-kafka-0-10-processors ......................... SUCCESS [  0.053 
s]
   [INFO] nifi-kafka-0-11-processors ......................... SUCCESS [  0.038 
s]
   [INFO] nifi-kafka-1-0-processors .......................... SUCCESS [  0.052 
s]
   [INFO] nifi-kafka-2-0-processors .......................... SUCCESS [  0.039 
s]
   [INFO] nifi-kafka-0-8-nar ................................. SUCCESS [  0.025 
s]
   [INFO] nifi-kafka-0-9-nar ................................. SUCCESS [  0.027 
s]
   [INFO] nifi-kafka-0-10-nar ................................ SUCCESS [  0.021 
s]
   [INFO] nifi-kafka-0-11-nar ................................ SUCCESS [  0.019 
s]
   [INFO] nifi-kafka-1-0-nar ................................. SUCCESS [  0.020 
s]
   [INFO] nifi-kafka-2-0-nar ................................. SUCCESS [  0.020 
s]
   [INFO] 
------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   [INFO] 
------------------------------------------------------------------------
   [INFO] Total time:  2.722 s
   [INFO] Finished at: 2019-06-17T13:52:57-04:00
   [INFO] 
------------------------------------------------------------------------
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to