mattyb149 commented on issue #3318: NiFi-5537 Add Cypher Bundle URL: https://github.com/apache/nifi/pull/3318#issuecomment-503655018 Overall this LGTM, I left one comment about the Mockito stuff, but the only functional comment I have left is that it is possible to have side effects on a query and have the flow file get routed to failure. For example, using GremlinClientService and your JanusGraph container, try this query: `g.addV('person').property('name','stephen')`. It routes the flow file to failure because it can't deserialize the "result", which I assume is because there's no real result at all. If you want to return the ID of the newly created vertex, you can use `g.addV('person').property('name','stephen').id()` and that gets routed to success. I'm not sure we can know whether side-effects occurred, I think we should just mention in the processor and/or controller service documentation that just because a flow file was routed to failure doesn't mean side effects didn't happen. Thoughts?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
