phrocker commented on a change in pull request #595: Add windows tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/595#discussion_r295483199
 
 

 ##########
 File path: nanofi/tests/CAPITests.cpp
 ##########
 @@ -145,8 +145,8 @@ TEST_CASE("get file and put file", "[getAndPutFile]") {
 
   char src_format[] = "/tmp/gt.XXXXXX";
   char put_format[] = "/tmp/pt.XXXXXX";
-  const char *sourcedir = testController.createTempDirectory(src_format);
-  const char *putfiledir = testController.createTempDirectory(put_format);
+  auto sourcedir = testController.createTempDirectory(src_format).c_str();
 
 Review comment:
   these are invalid assignments of the underlying rvalues 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to