[
https://issues.apache.org/jira/browse/NIFI-5373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867950#comment-16867950
]
ASF subversion and git services commented on NIFI-5373:
-------------------------------------------------------
Commit 82a6c430a4cea116d011991173f867c8bc3fc35e in nifi's branch
refs/heads/master from Jeff Storck
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=82a6c43 ]
NIFI-5373 Created new module nifi-metrics
In nifi-metrics, added build-helper-maven-plugin to enable groovy tests to run,
since there are no java tests or src/test/java path in the module
Replaced yammer/dropwizard's VirtualMachineMetrics usage in multiple modules
with JvmMetrics interface and JmxJvmMetrics implementation in nifi-metrics
Updated nifi-datadog-reporting-task to use nifi-metrics:1.10.0-SNAPSHOT
Updated nifi-scripting-bundle to use nifi-metrics:1.10.0-SNAPSHOT
Updated ScriptedReportingTask to use JmxJvmMetrics instead of
VirtualMachineMetrics
Updated nifi-reporting-utils pom to use nifi-metrics:1.10.0-SNAPSHOT
Updated nifi-ambari-reporting-task pom to use nifi-metrics:1.10.0-SNAPSHOT
Updated SiteToSiteMetricsReportingTask to use nifi-metrics:1.10.0-SNAPSHOT
Updated ScriptedReportingTaskGroovyTest to use regular strings instead of
GStrings due to class cast exception
Updated nifi-prometheus-reporting-task to use nifi-metrics:1.10.0-SNAPSHOT
Updated PrometheusMetricsUtil to use LF endings instead of CRLF
Updated nifi-metrics-reporting-bundle and its submodules to use
nifi-metrics:1.10.0-SNAPSHOT
nifi-metrics-reporting-task metrics-graphite version upgraded from 3.1.2 to
4.1.0
Removed unused property yammer.metrics.version from nifi-jolt-record-bundle pom
Updated root NOTICE to include derived work in nifi-metrics
Removed duplicate nifi-assembly NOTICE clauses for yammer/dropwizard metrics
Removed unnecessary inclusion of Yammer Metrics in Kafka 0-9, 0-10, 0-11, 1-0,
and 2-0 NARs' NOTICE files since the Kafka dependency that transitively
includes it is test-scoped.
Removed unnecessary mock interaction in GraphiteMetricReporterServiceTest,
Mockito 2.28.2 operates in strict mode and flags unused unused interactions.
NIFI-6354: Added LICENSE and NOTICE for nifi-kafka-2-0-nar
Updated NOTICE in kafka nar modules to reflect the actual module names at the
top of the NOTICE
Added yammer metrics NOTICE clauses to nifi-kafka-0-11-nar
Added yammer metrics NOTICE clauses to nifi-kafka-1-0-nar
NIFI-6355: Extended NOTICE clauses for yammer/dropwizard metrics in multiple
modules
Signed-off-by: Matthew Burgess <[email protected]>
This closes #3520
> Create Metrics API and default implementation
> ---------------------------------------------
>
> Key: NIFI-5373
> URL: https://issues.apache.org/jira/browse/NIFI-5373
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.7.0
> Reporter: Jeff Storck
> Assignee: Jeff Storck
> Priority: Major
> Labels: Java11
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> A decoupling of the metrics library used by several reporting components by
> providing a similar API in the nifi-api module (under a new package
> org.apache.nifi.metrics.jvm) will help internalize the dependencies on the
> yammer/dropwizard metrics libraries and reduce the number of dependencies
> that NiFi extensions need to collect those types of metrics.
> While working towards support for building NiFi on Java 10+, tests for
> components that use the com.yammer.metrics:metrics-core:2.2.0 dependency are
> failing due to references to internal JDK modules. These metrics libraries
> are now maintained dropwizard, and a new version (4.0.0) has been released
> that works with Java 10.
> The public API for the metrics libraries has changed a bit, and
> VirtualMachineMetrics is no longer available. NiFi will supply its own
> public API for metrics that is derived from dropwizard/yammer's
> VirtualMachineMetrics to minimize impact to NiFi extensions that currently
> use this dependency.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
