arpadboda commented on a change in pull request #580: MINIFICPP-30: Add support
for regex with Multiple file mode
URL: https://github.com/apache/nifi-minifi-cpp/pull/580#discussion_r296632682
##########
File path: libminifi/include/utils/StringUtils.h
##########
@@ -36,7 +36,11 @@ enum TimeUnit {
MILLISECOND,
NANOSECOND
};
-
+#if (__cplusplus >= 201103L && (!defined(__GLIBCXX__) || (__cplusplus >=
201402L) || (defined(_GLIBCXX_RELEASE) && _GLIBCXX_RELEASE > 4)))
Review comment:
If I remember well that's gonna fail for Win given the way MS handled
__cplusplus before:
https://devblogs.microsoft.com/cppblog/msvc-now-correctly-reports-__cplusplus/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
