phrocker commented on a change in pull request #597: MINIFICPP-933: Fix raw
site to site with secure comms
URL: https://github.com/apache/nifi-minifi-cpp/pull/597#discussion_r297730386
##########
File path: libminifi/include/utils/StringUtils.h
##########
@@ -105,7 +105,8 @@ class StringUtils {
* @param s incoming string
* @returns modified string
*/
- static inline std::string trimLeft(std::string s) {
+ static inline std::string trimLeft(const std::string &in_string) {
+ auto s = in_string;
Review comment:
fwiw I was testing was optimizations on godbolt of varying compilers with
varying string lengths ( to impose SSO ) and compilers to look at how string
interning would impact the resulting assembler output. Frankly even though I
"preferred" the semantics of the prototype I didn't change the functional
semantics and actually made it worse at optimization levels < 2! I didn't
intend to include but will still run the various tests I ran just to be
cautious and remove those sleeps!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
