phrocker commented on a change in pull request #596: MINIFICPP-925 - Fix
TailFile hang on long lines
URL: https://github.com/apache/nifi-minifi-cpp/pull/596#discussion_r297790102
##########
File path: extensions/standard-processors/processors/LogAttribute.h
##########
@@ -90,26 +90,19 @@ class LogAttribute : public core::Processor {
class ReadCallback : public InputStreamCallback {
public:
ReadCallback(uint64_t size)
- : read_size_(0) {
- buffer_size_ = size;
- buffer_ = new uint8_t[buffer_size_];
- }
- ~ReadCallback() {
- if (buffer_)
- delete[] buffer_;
+ : buffer_(size) {
}
int64_t process(std::shared_ptr<io::BaseStream> stream) {
- int64_t ret = 0;
- ret = stream->read(buffer_, buffer_size_);
- if (!stream)
- read_size_ = stream->getSize();
- else
- read_size_ = buffer_size_;
- return ret;
+ if (buffer_.size() == 0U) {
+ return 0U;
+ }
+ int ret = stream->read(buffer_.data(), buffer_.size());
Review comment:
Let's leave my comment at this since this is what I mostly care about: I
don't mind the change in behavior ( exhibited or theoretical as partial reads
should be possible and supported) -- but can you add a log statement to show
how many bytes were read vs requested?
This processor is used chiefly as a debug tool. Notwithstanding the issues
you resolved, if the number of bytes read != stream, I think the user would
want to know about that and it may help us triage a potential problem in a repo
or stream.
That would mean the flow file size does not match the content size -- and I
don't know if that would come across very well even with the code that exists
in master -- in fact the spurious rollback with no reason would probably be
more confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
